Generate RBIs for vendored gems #2492
Conversation
paracycle
left a comment
paracycle
left a comment
There was a problem hiding this comment.
I am not sure what the best path forward for your use-case would be, but I am happy to discuss alternatives. It will definitely not be the current solution.
|
|
||
| #: (String gemfile_dir) -> bool | ||
| def ignore?(gemfile_dir) | ||
| gem_ignored? || gem_in_app_dir?(gemfile_dir, full_gem_path) |
There was a problem hiding this comment.
I am afraid this won't be enough since the condition exists for a specific reason: In our core monolith at Shopify we have what we call "in-repo gems" which are gems that exist inside folders under the app path. Since they are under the app path, they already get type-checked by Sorbet, so we should not be generating extra RBI files for them as well. For all practical purposes, the code in those paths in our Core monolith is a part of the monolith even though it gets loaded as a gem.
Your case is similar but somewhat different. You load some actual gems from the vendor folder inside your app path, so you want to generate RBIs for them, but removing this condition will break our use-case.
There was a problem hiding this comment.
Ah I see. I tried adding typechecking to these gems and was able to work through the issues. Thanks 👍
2 participants
Motivation
Addresses #343
We have some vendored gems in
vendor/gems. Note that this is not our BUNDLE_PATH. We just point to some gems by using thepath:option in the Gemfile. Without this change tapioca doesn't compile rbis for these gems.Implementation
There was an ignore condition that ignored any gems in the app dir. This removes it.
Tests
Added