Skip to content

Upgrade from minitest 5.27.0 to minitest 6.0.1 for Rails 8.1 #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
larouxn wants to merge 1 commit into
base: main
Choose a base branch
from
+310 −455
Open

Upgrade from minitest 5.27.0 to minitest 6.0.1 for Rails 8.1 #2491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,15 @@ gemspec
CURRENT_RAILS_VERSION = "8.1"
rails_version = ENV.fetch("RAILS_VERSION", CURRENT_RAILS_VERSION)

gem "minitest", "< 6.0" # Rails 8.1.1 doesn't support minitest 6.0 which causes errors
# Rails main and 8.1.2 onward support Minitest 6.
# Rails 8.0.x lacks support for Minitest 6 in released versions.
# TODO: Remove conditional once a Rails 8.0.x release with Minitest 6 support is cut.
# See: https://github.com/rails/rails/commit/ec62932ee7d31e0ef870e61c2d7de2c3efe3faa6
if rails_version == "8.0"
gem "minitest", "< 6"
else
gem "minitest"
end
gem "minitest-hooks"
gem "minitest-reporters"
gem "debug"
Expand Down
5 changes: 3 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,8 @@ GEM
net-smtp
marcel (1.1.0)
mini_mime (1.1.5)
minitest (5.27.0)
minitest (6.0.1)
prism (~> 1.5)
minitest-hooks (1.5.3)
minitest (> 5.3)
minitest-reporters (1.7.1)
Expand Down Expand Up @@ -443,7 +444,7 @@ DEPENDENCIES
json_api_client!
kramdown (~> 2.5)
kredis
minitest (< 6.0)
minitest
minitest-hooks
minitest-reporters
mutex_m
Expand Down
Loading