Skip to content

Make trigger_reload return success/failure status #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KaanOzkan wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Make trigger_reload return success/failure status #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ruby_lsp/ruby_lsp_rails/runner_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,10 +239,10 @@ def delegate_request(server_addon_name:, request_name:, **params)
nil
end

#: -> void
#: -> Hash[Symbol, untyped]?
def trigger_reload
log_message("Reloading Rails application")
send_notification("reload")
make_request("reload")
rescue MessageError
log_message(
"Ruby LSP Rails failed to trigger reload",
Expand Down
8 changes: 7 additions & 1 deletion lib/ruby_lsp/ruby_lsp_rails/server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,8 +321,14 @@ def execute(request, params)
end
when "reload"
with_progress("rails-reload", "Reloading Ruby LSP Rails instance") do
with_notification_error_handling(request) do
begin
::Rails.application.reloader.reload!
send_result({ success: true })
rescue StandardError => e
log_message(
"Request reload failed with #{e.class}:\n#{e.full_message(highlight: false)}",
)
send_result({ success: false })
end
end
when "route_location"
Expand Down
Loading