Skip to content

Add a block type event#898

Open
LasmarKhalifa wants to merge 1 commit into
mainfrom
05-27/add-block-event-type
Open

Add a block type event#898
LasmarKhalifa wants to merge 1 commit into
mainfrom
05-27/add-block-event-type

Conversation

@LasmarKhalifa
Copy link
Copy Markdown
Contributor

@LasmarKhalifa LasmarKhalifa commented May 27, 2026

The current formatting chosen is one of 3 options that we could decide to go with for this change.

Different formatting choices we can have:

1.
Screenshot 2026-05-28 at 10.55.59 AM.png

2.
Screenshot 2026-05-28 at 10.55.07 AM.png

3.
Screenshot 2026-05-28 at 10.54.13 AM.png

I think option 2 is the cleanest one, but open to other opinions.

Copy link
Copy Markdown
Contributor Author

LasmarKhalifa commented May 27, 2026

@LasmarKhalifa LasmarKhalifa changed the title A\dd a block type event Add a block type event May 27, 2026
@LasmarKhalifa LasmarKhalifa force-pushed the 05-27/add-block-event-type branch from f0c490d to b0b935b Compare May 27, 2026 20:23
@LasmarKhalifa LasmarKhalifa changed the base branch from 05-19/repeat-log-prefix-on-each-line to graphite-base/898 May 28, 2026 19:49
@LasmarKhalifa LasmarKhalifa force-pushed the 05-27/add-block-event-type branch from b0b935b to 0568236 Compare May 28, 2026 19:49
@graphite-app graphite-app Bot changed the base branch from graphite-base/898 to main May 28, 2026 19:50
@LasmarKhalifa LasmarKhalifa force-pushed the 05-27/add-block-event-type branch from 0568236 to fa160f5 Compare May 28, 2026 19:50
Comment thread test/roast/event_monitor_test.rb Outdated
@LasmarKhalifa LasmarKhalifa force-pushed the 05-27/add-block-event-type branch from fa160f5 to 82ea8c7 Compare May 28, 2026 21:11
@LasmarKhalifa LasmarKhalifa marked this pull request as ready for review May 28, 2026 21:12
@LasmarKhalifa LasmarKhalifa requested a review from dersam May 28, 2026 21:15
@LasmarKhalifa LasmarKhalifa force-pushed the 05-27/add-block-event-type branch from 82ea8c7 to f828b8d Compare May 28, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants