fix(🔺): scale WebGPUCanvas surface to device pixel resolution#3763
Open
kbrandwijk wants to merge 1 commit intoShopify:mainfrom
Open
fix(🔺): scale WebGPUCanvas surface to device pixel resolution#3763kbrandwijk wants to merge 1 commit intoShopify:mainfrom
kbrandwijk wants to merge 1 commit intoShopify:mainfrom
Conversation
WebGPUCanvas was creating its surface at point dimensions instead of pixel dimensions. On high-DPI devices (e.g., iPhone 16 Pro at 3x), this resulted in a 402×874 surface instead of 1206×2622. Multiply getBoundingClientRect dimensions by PixelRatio.get() before passing to MakeWebGPUCanvasContext. Web is excluded (scale = 1) since browser canvas handles DPR separately. Fixes Shopify#3762 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebGPUCanvas was creating its surface at point dimensions instead of pixel dimensions. On high-DPI devices (e.g., iPhone 16 Pro at 3x), this resulted in a 402×874 surface instead of 1206×2622, causing blurry/low-resolution rendering.
Fix
Multiply
getBoundingClientRect()dimensions byPixelRatio.get()before passing toMakeWebGPUCanvasContext. Web is excluded (scale = 1) since browser canvas handles DPR separately.Test plan
Fixes #3762