Move self handling to variable lookup#2081
Open
jg-rp wants to merge 1 commit intoShopify:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shows an alternative implementation of
selfby removingSelfDropand moving handling ofselffromContexttoVariableLookup.This approach changes
selfsemantics to fix the issue identified in #2080. Instead of conditionally replacingselfwith a drop, we now fall back to top-level variable resolution ifself[key]does not exist.A comforting side effect is that
selfcan no longer be aliased with{% assign this = self %}, or be passed as an argument{% render 'snippet', this: self %}(this does not cause too much of a problem becauseSelfDrop.contextis always replaced with the current context).(Edit: My assumptions about the intended scoping rules for
selfmight not be quite right.)