Fix locale-param flag sharing same env var as adapter flag#3693
Open
J8118 wants to merge 2 commits intoShopify:mainfrom
Open
Fix locale-param flag sharing same env var as adapter flag#3693J8118 wants to merge 2 commits intoShopify:mainfrom
J8118 wants to merge 2 commits intoShopify:mainfrom
Conversation
fredericoo
approved these changes
Apr 13, 2026
Contributor
fredericoo
left a comment
fredericoo
left a comment
There was a problem hiding this comment.
LGTM - copy-paste bug, both flags sharing the same env var is clearly wrong.
andguy95
approved these changes
Apr 13, 2026
fredericoo
requested changes
Apr 15, 2026
Contributor
fredericoo
left a comment
fredericoo
left a comment
There was a problem hiding this comment.
please add a changeset, as this impacts users. it seems like no one has used this as no one has ever flagged anything!
Contributor
Author
|
Done — just pushed a changeset to the branch. |
Both the adapter and locale-param flags used SHOPIFY_HYDROGEN_FLAG_ADAPTER. Setting this env var would incorrectly set both flags to the same value. Changed locale-param to use SHOPIFY_HYDROGEN_FLAG_LOCALE_PARAM.
J8118
force-pushed
the
fix/duplicate-env-var-generate-route
branch
from
62ca3cc to
19c2a4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
generate/route.ts, both theadapterflag (line 24) and thelocale-paramflag (line 33) use the same environment variableSHOPIFY_HYDROGEN_FLAG_ADAPTER. If a user sets this env var, oclif will use the value for both flags — an adapter name like@shopify/remix-oxygenwill also be used as the locale param name, which is clearly wrong.File changed:
packages/cli/src/commands/hydrogen/generate/route.ts(line 33)Before:
After: