Skip to content

[Tests] Replace filesystem mocks with real temp dir in replay.test.ts#7484

Draft
gonzaloriestra wants to merge 1 commit intomainfrom
tester-refactor-replay-test-fs-mock-removal-7909328793477070431
Draft

[Tests] Replace filesystem mocks with real temp dir in replay.test.ts#7484
gonzaloriestra wants to merge 1 commit intomainfrom
tester-refactor-replay-test-fs-mock-removal-7909328793477070431

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The replay.test.ts file was using manual filesystem mocks (vi.mock('fs') and vi.mock('@shopify/cli-kit/node/fs')) to simulate log file discovery and reading. This made the tests brittle and less representative of real behavior, as they were testing the mocks instead of the actual file-discovery and sorting logic.

WHAT is this pull request doing?

This PR refactors packages/app/src/cli/services/function/replay.test.ts to:

  • Use testWithTempDir to provide an isolated temporary directory for each test.
  • Replace all vi.mock('fs') and @shopify/cli-kit/node/fs mocks with real filesystem operations.
  • Introduce a writeFunctionRunFiles helper to populate the temporary directory with deterministic log files.
  • Update assertions to reflect the actual sorting behavior of the replay service.

How to test your changes?

Run the unit tests for the replay service:

pnpm --filter @shopify/app vitest run replay.test.ts

Duplicate check

I ran git log --grep="\[Tests\]" --grep="replay.test.ts" --all-match and found no previous PRs targeting this specific test file with these improvements.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type and added a changeset with pnpm changeset add (N/A for tests)

PR label: Jules (exact casing)


PR created automatically by Jules for task 7909328793477070431 started by @gonzaloriestra

Refactors packages/app/src/cli/services/function/replay.test.ts to use real
temporary directories and filesystem operations instead of mocks. This
improves test reliability and ensures the actual file-discovery and
sorting logic is exercised.

- Removed vi.mock('fs') and vi.mock('@shopify/cli-kit/node/fs')
- Switched to testWithTempDir fixture
- Added deterministic log file creation in tests
- Fixed lint and type issues in the test file
- Verified all tests pass with real filesystem operations
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant