Skip to content

Remove unused 'Breaking change approval' job #7468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alfonso-noriega wants to merge 1 commit into
base: graphite-base/7468
Choose a base branch
from
+2 −13
Draft

Remove unused 'Breaking change approval' job #7468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions .github/workflows/tests-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,16 +331,5 @@ jobs:
- name: Fail if breaking changes detected
if: steps.check.outputs.has_breaking_changes == 'true'
run: |
echo '::error::Breaking changes detected. A member of @shopify/dev_experience must approve the breaking-change-approval environment.'
echo '::error::Breaking changes detected. See the sticky comment on the PR for details.'
exit 1

major-change-approval:
name: 'Breaking change approval'
needs: major-change-check
if: always() && needs.major-change-check.outputs.has_breaking_changes == 'true'
runs-on: ubuntu-latest
timeout-minutes: 5
environment: breaking-change-approval
steps:
- name: Approved
run: echo '✅ Breaking changes approved by dev_experience team member'
2 changes: 1 addition & 1 deletion workspace/src/major-change-check.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,7 @@ function buildReport({majorChangesets, manifestChanges, schemaChanges}) {

This PR contains changes that may break the existing contract.

**@shopify/dev_experience** — this PR contains breaking changes that require coordination for the next major release. This check will remain failed until a member of the team approves the workflow run.
**@shopify/dev_experience** — this PR contains breaking changes that require coordination for the next major release.

> 💬 Head to [#help-dev-platform](https://shopify.enterprise.slack.com/archives/C07UJ7UNMTK) to discuss timing and plan the release.

Expand Down
Loading