[3.92] Revert "Fix 401 Unauthorized on cart AJAX endpoints during shopify theme dev"#6992
Merged
karreiro merged 1 commit intostable/3.92from Mar 12, 2026
Merged
[3.92] Revert "Fix 401 Unauthorized on cart AJAX endpoints during shopify theme dev"#6992karreiro merged 1 commit intostable/3.92from
shopify theme dev"#6992karreiro merged 1 commit intostable/3.92from
Conversation
This comment has been minimized.
This comment has been minimized.
shopify theme dev"
EvilGenius13
approved these changes
Mar 12, 2026
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationspackages/cli-kit/dist/public/node/toml.d.tsimport { JsonMap } from '../../private/common/json.js';
export type JsonMapType = JsonMap;
/**
* Given a TOML string, it returns a JSON object.
*
* @param input - TOML string.
* @returns JSON object.
*/
export declare function decodeToml(input: string): JsonMapType;
/**
* Given a JSON object, it returns a TOML string.
*
* @param content - JSON object.
* @returns TOML string.
*/
export declare function encodeToml(content: JsonMap | object): string;
Existing type declarationspackages/cli-kit/dist/public/node/git.d.ts@@ -1,13 +1,5 @@
import { AbortError } from './error.js';
-export interface GitLogEntry {
- hash: string;
- date: string;
- message: string;
- refs: string;
- body: string;
- author_name: string;
- author_email: string;
-}
+import { DefaultLogFields, ListLogLine } from 'simple-git';
/**
* Initialize a git repository at the given directory.
*
@@ -48,12 +40,14 @@ export declare function addToGitIgnore(root: string, entry: string): void;
*
* @param repoUrl - The URL of the repository to clone.
* @param destination - The directory where the repository will be cloned.
+ * @param progressUpdater - A function that will be called with the progress of the clone.
* @param shallow - Whether to clone the repository shallowly.
* @param latestTag - Whether to clone the latest tag instead of the default branch.
*/
export interface GitCloneOptions {
repoUrl: string;
destination: string;
+ progressUpdater?: (statusString: string) => void;
shallow?: boolean;
latestTag?: boolean;
}
@@ -70,7 +64,7 @@ export declare function downloadGitRepository(cloneOptions: GitCloneOptions): Pr
* @param directory - The directory of the git repository.
* @returns The latest commit of the repository.
*/
-export declare function getLatestGitCommit(directory?: string): Promise<GitLogEntry>;
+export declare function getLatestGitCommit(directory?: string): Promise<DefaultLogFields & ListLogLine>;
/**
* Add all files to the git index from the given directory.
*
|
Contributor
Coverage report
Test suite run success3776 tests passing in 1448 suites. Report generated by 🧪jest coverage report action from ed1bf34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #6975