Add success status and store fqdn to hydrogen CLI commands#6959
Draft
Add success status and store fqdn to hydrogen CLI commands#6959
Conversation
Contributor
Coverage report
Test suite run success3799 tests passing in 1450 suites. Report generated by 🧪jest coverage report action from b067d64 |
c013408 to
b067d64
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/hooks/prerun.d.ts@@ -1,4 +1,4 @@
-import { Hook } from '@oclif/core';
+import { Hook, Interfaces } from '@oclif/core';
export declare interface CommandContent {
command: string;
topic?: string;
@@ -10,7 +10,6 @@ export declare function parseCommandContent(cmdInfo: {
aliases: string[];
pluginAlias?: string;
}): CommandContent;
-/**
- * Warns the user if there is a new version of the CLI available
- */
+export declare function interceptProcessExit(config: Interfaces.Config): void;
+export declare function extractStoreMetadata(argv: string[]): Promise<void>;
export declare function warnOnAvailableUpgrade(): Promise<void>;
\ No newline at end of file
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist