Skip to content

Add success status and store fqdn to hydrogen CLI commands#6959

Draft
lucyxiang wants to merge 1 commit intomainfrom
03-09-add_success_status_and_store_fqdn_to_hydrogen_cli_commands
Draft

Add success status and store fqdn to hydrogen CLI commands#6959
lucyxiang wants to merge 1 commit intomainfrom
03-09-add_success_status_and_store_fqdn_to_hydrogen_cli_commands

Conversation

@lucyxiang
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.84% 14504/18396
🟡 Branches 73.16% 7214/9861
🟡 Functions 79.08% 3700/4679
🟡 Lines 79.18% 13699/17301

Test suite run success

3799 tests passing in 1450 suites.

Report generated by 🧪jest coverage report action from b067d64

@lucyxiang lucyxiang force-pushed the 03-09-add_success_status_and_store_fqdn_to_hydrogen_cli_commands branch from c013408 to b067d64 Compare March 9, 2026 19:40
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/hooks/prerun.d.ts
@@ -1,4 +1,4 @@
-import { Hook } from '@oclif/core';
+import { Hook, Interfaces } from '@oclif/core';
 export declare interface CommandContent {
     command: string;
     topic?: string;
@@ -10,7 +10,6 @@ export declare function parseCommandContent(cmdInfo: {
     aliases: string[];
     pluginAlias?: string;
 }): CommandContent;
-/**
- * Warns the user if there is a new version of the CLI available
- */
+export declare function interceptProcessExit(config: Interfaces.Config): void;
+export declare function extractStoreMetadata(argv: string[]): Promise<void>;
 export declare function warnOnAvailableUpgrade(): Promise<void>;
\ No newline at end of file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant