Skip to content

Generate types for shared folders#6957

Open
justinhenricks wants to merge 3 commits intomainfrom
generate-for-shared-folders
Open

Generate types for shared folders#6957
justinhenricks wants to merge 3 commits intomainfrom
generate-for-shared-folders

Conversation

@justinhenricks
Copy link

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@justinhenricks justinhenricks requested a review from a team as a code owner March 9, 2026 16:00
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@binks-code-reviewer
Copy link

binks-code-reviewer bot commented Mar 9, 2026

🤖 Code Review · #projects-dev-ai for questions
React with 👍/👎 or reply — all feedback helps improve the agent.

Complete - No issues

📋 History

✅ 1 findings → ✅ No issues

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.27% 14626/18450
🟡 Branches 73.58% 7266/9875
🟡 Functions 79.43% 3726/4691
🟡 Lines 79.6% 13818/17360

Test suite run success

3831 tests passing in 1468 suites.

Report generated by 🧪jest coverage report action from d22ff3b

@robin-drexler robin-drexler force-pushed the generate-for-shared-folders branch from b207899 to d22ff3b Compare March 11, 2026 20:06
@robin-drexler
Copy link
Member

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @robin-drexler! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260311200812

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants