Gate tools and instructions behind Remote DOM api_version check#6948
Open
vividviolet wants to merge 1 commit intomainfrom
Open
Gate tools and instructions behind Remote DOM api_version check#6948vividviolet wants to merge 1 commit intomainfrom
vividviolet wants to merge 1 commit intomainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
ef0c537 to
5d3f2dd
Compare
5d3f2dd to
86ef403
Compare
|
🤖 Code Review · #projects-dev-ai for questions ✅ Complete - No issues 📋 History✅ No issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Only add tools and instructions to the build_manifest for ui_extension when isRemoteDomExtension is true (
api_version >= 2025-10). Previously these were unconditionally included regardless of api_version even though they are not supported.Also fixes the isRemoteDomExtension type guard return type from
ExtensionInstance<{api_version: string}>['configuration'](which lost all other config properties) toExtensionInstance['configuration'] & {api_version: string}(which preserves them while narrowing api_version).Changes:
ui_extension.ts:
ui_extension.test.ts:
Testing
All unit tests should pass