Skip to content

Gate tools and instructions behind Remote DOM api_version check#6948

Open
vividviolet wants to merge 1 commit intomainfrom
trish-ta/gate-tools-instructions-remote-dom
Open

Gate tools and instructions behind Remote DOM api_version check#6948
vividviolet wants to merge 1 commit intomainfrom
trish-ta/gate-tools-instructions-remote-dom

Conversation

@vividviolet
Copy link
Member

@vividviolet vividviolet commented Mar 6, 2026

What:

Only add tools and instructions to the build_manifest for ui_extension when isRemoteDomExtension is true (api_version >= 2025-10). Previously these were unconditionally included regardless of api_version even though they are not supported.

Also fixes the isRemoteDomExtension type guard return type from ExtensionInstance<{api_version: string}>['configuration'] (which lost all other config properties) to ExtensionInstance['configuration'] & {api_version: string} (which preserves them while narrowing api_version).

Changes:

ui_extension.ts:

  • In the UIExtensionSchema transform, compute whether the config qualifies as Remote DOM and only spread tools/instructions into build_manifest assets when true
  • tools and instructions on the extension point object are set to undefined for non-Remote-DOM versions
  • Fixed isRemoteDomExtension type guard return type

ui_extension.test.ts:

  • Updated existing tools/instructions build_manifest tests to use api_version: '2025-10'
  • Added 2 new negative tests confirming tools/instructions are excluded for non-Remote-DOM api versions
  • Updated setupToolsExtension helper to default to '2025-10' with an apiVersion option
  • Renamed test descriptions to clarify Remote DOM version dependency

Testing

All unit tests should pass

@vividviolet vividviolet requested a review from a team as a code owner March 6, 2026 21:57
@github-actions

This comment has been minimized.

@vividviolet vividviolet force-pushed the trish-ta/gate-tools-instructions-remote-dom branch from ef0c537 to 5d3f2dd Compare March 6, 2026 22:17
@vividviolet vividviolet requested a review from a team as a code owner March 6, 2026 22:17
@vividviolet vividviolet force-pushed the trish-ta/gate-tools-instructions-remote-dom branch from 5d3f2dd to 86ef403 Compare March 6, 2026 22:20
@binks-code-reviewer
Copy link

🤖 Code Review · #projects-dev-ai for questions
React with 👍/👎 or reply — all feedback helps improve the agent.

Complete - No issues

📋 History

✅ No issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant