Skip to content

Use the React Router template in acceptance tests #6776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 1 commit into from
Jan 19, 2026
+7 −8
Merged

Use the React Router template in acceptance tests #6776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/features/features/app.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ Feature: Apps
Background:
Given I have a working directory

Scenario: I scaffold ui, theme and function extensions in a remix app
And I create a remix app named MyExtendedApp with npm as package manager
Scenario: I scaffold ui, theme and function extensions in a react-router app
And I create a react-router app named MyExtendedApp with npm as package manager
# When I create an extension named TestPurchaseExtensionReact of type post_purchase_ui and flavor react
# Then I have an extension named TestPurchaseExtensionReact of type checkout_post_purchase and flavor react
# When I create an extension named TestThemeExtension of type theme_app_extension
Expand Down
11 changes: 5 additions & 6 deletions packages/features/steps/create-app.steps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ When(
/I create a (.+) app named (.+) with (.+) as package manager/,
{timeout: 5 * 60 * 1000},
async function (appType: string, appName: string, packageManager: string) {
let template
let templateArgs
switch (appType) {
case 'remix':
template = 'https://github.com/Shopify/shopify-app-template-remix'
case 'react-router':
templateArgs = ['--template', 'reactRouter', '--flavor', 'javascript']
break
case 'extension-only':
template = 'https://github.com/Shopify/shopify-app-template-none'
templateArgs = ['--template', 'none']
break
default:
throw new Error(`Unknown app type: ${appType}`)
Expand All @@ -73,8 +73,7 @@ When(
'--package-manager',
packageManager,
'--local',
'--template',
template,
...templateArgs,
],
{env: {...process.env, ...this.temporaryEnv, NODE_OPTIONS: '', FORCE_COLOR: '0'}},
)
Expand Down
Loading