-
Notifications
You must be signed in to change notification settings - Fork 223
Fix local store domain #6735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix local store domain #6735
Conversation
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3582 tests passing in 1420 suites. Report generated by 🧪jest coverage report action from 86748ac |
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
WHY are these changes introduced?
Related to https://github.com/shop/issues-bundles-and-combined-listings/issues/1250
When running
app devagainst local, the App Home link points tohttps://dev-store-local.my.shop.dev/admin/oauth/redirect_from_cli?client_id=xxx, which throws a 404:Related discussion: https://shopify.slack.com/archives/C08GKEEKXGE/p1765883873388589
WHAT is this pull request doing?
Replaces
.my.shop.devwith.dev-api.shop.dev, which is apparently required for the OAuth flow: https://github.com/Shopify/dev_server?tab=readme-ov-file#shop-redirectsHow to test your changes?
SHOPIFY_CLI_NEVER_USE_PARTNERS_API=1 SHOPIFY_SERVICE_ENV=local pnpm shopify app devMeasuring impact
How do we know this change was effective? Please choose one:
Checklist