Return ParseDetails from Parse trait instead of Result directly
#80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
force-pushed
the
parser-improve-result
branch
from
e6aa60f to
32f595b
Compare
adampetro
reviewed
Nov 11, 2025
swalkinshaw
force-pushed
the
parser-improve-result
branch
2 times, most recently
from
5e1344b to
7cb7ec4
Compare
swalkinshaw
changed the title
ParseResult from Parse trait instead of Result directlyParseDetails from Parse trait instead of Result directly
adampetro
reviewed
Nov 12, 2025
swalkinshaw
force-pushed
the
parser-improve-result
branch
from
7cb7ec4 to
87ffe6b
Compare
The Parse trait now returns `ParseDetails` instead of a `Result` to more accurately reflect that result information can always be returned and not only for success cases. This exposes the token count now regardless of success or failure. Even when the parser returns an error, there's still a token count.
swalkinshaw
force-pushed
the
parser-improve-result
branch
from
87ffe6b to
c9c3f39
Compare
adampetro
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #72
The Parse trait now returns
ParseDetailsinstead of aResultto more accurately reflect that result information will always be returned and not only for success cases.This exposes the token count now regardless of success or failure. Even when the parser returns an error, there's still a token count.