Skip to content

Install build_geometry and validate_geometry executables#17

Merged
olantwin merged 1 commit into
mainfrom
feat/install-apps
May 13, 2026
Merged

Install build_geometry and validate_geometry executables#17
olantwin merged 1 commit into
mainfrom
feat/install-apps

Conversation

@olantwin
Copy link
Copy Markdown
Contributor

@olantwin olantwin commented May 13, 2026

Summary

  • Install the build_geometry and validate_geometry apps so they are available in the deployed package
  • Needed by the shipdist geometry recipe to generate a pre-built .db file at install time

Summary by CodeRabbit

  • Chores
    • Installation configuration updated to include build_geometry and validate_geometry command-line tools. These utilities are now bundled with the package and available for direct use from the terminal, enabling users to perform geometry building and validation operations without additional setup.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 87c66863-2188-4f93-a0c1-d87b81426400

📥 Commits

Reviewing files that changed from the base of the PR and between 5ebf349 and 3f2baa5.

📒 Files selected for processing (1)
  • CMakeLists.txt

📝 Walkthrough

Walkthrough

CMakeLists.txt installation rules are extended to include runtime installation for build_geometry and validate_geometry executables to the binary installation directory alongside existing library and subsystem exports.

Changes

Executable Installation

Layer / File(s) Summary
Executable target installation
CMakeLists.txt
The install(TARGETS ...) block now installs build_geometry and validate_geometry executables with RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}, extending the installation manifest beyond libraries and subsystems.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: installing two specific executables (build_geometry and validate_geometry) as part of the CMakeLists.txt modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/install-apps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@olantwin olantwin force-pushed the feat/install-apps branch from a26f22d to 9022d14 Compare May 13, 2026 12:06
These were built but not installed. Installing them allows the geometry
database to be generated as part of the package deployment.
@olantwin olantwin force-pushed the feat/install-apps branch from 9022d14 to 3f2baa5 Compare May 13, 2026 13:42
@olantwin olantwin merged commit 5002aa5 into main May 13, 2026
3 checks passed
@olantwin olantwin deleted the feat/install-apps branch May 13, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant