Explicit control-structure schema edges#1849
Merged
SuperUserDone merged 2 commits intomasterfrom Mar 18, 2026
Merged
Conversation
ml86
approved these changes
Mar 18, 2026
| } | ||
| } | ||
|
|
||
| "accept explicit control-structure body edges" in { |
Contributor
There was a problem hiding this comment.
We do not add tests to check whether individual edges or nodes can be added or more generally handled by the graph since they are completely handled by generated code.
Please remove this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the edges discussed in: https://github.com/ShiftLeftSecurity/codescience/issues/8765
Resolves: https://github.com/ShiftLeftSecurity/codescience/issues/8801
I think the edges are defined now as they should be @ml86. I found the AST.scala hard to follow, lmk if I missed something.
Not sure what the testing requirements are for this. The other edges don't seem to have tests unless I missed it.
Joern side: joernio/joern#5890