Skip to content

fix: Windows GPU detection — deploy.bat quoting bug + env_config WMI …#145

Merged
solderzzc merged 2 commits intodevelopfrom
feature/windows-deploy-bat
Mar 10, 2026
Merged

fix: Windows GPU detection — deploy.bat quoting bug + env_config WMI …#145
solderzzc merged 2 commits intodevelopfrom
feature/windows-deploy-bat

Conversation

@solderzzc
Copy link
Member

…fallback

  • deploy.bat: Replace for /f single-quote syntax with temp-file redirection to fix CMD quoting conflict that truncated Python command
  • deploy.bat: Use os.environ['ENV_CONFIG_DIR'] instead of r'...' to avoid all quoting issues in inline Python
  • env_config.py: Add Windows well-known path search for nvidia-smi (Program Files/NVSMI, System32)
  • env_config.py: Add _try_cuda_wmi() fallback using wmic win32_VideoController for Windows systems without nvidia-smi on PATH
  • New test_env_config_cuda.py: 16 test cases covering nvidia-smi, Windows path search, WMI fallback, and detect() integration

…fallback

- deploy.bat: Replace for /f single-quote syntax with temp-file
  redirection to fix CMD quoting conflict that truncated Python command
- deploy.bat: Use os.environ['ENV_CONFIG_DIR'] instead of r'...' to
  avoid all quoting issues in inline Python
- env_config.py: Add Windows well-known path search for nvidia-smi
  (Program Files/NVSMI, System32)
- env_config.py: Add _try_cuda_wmi() fallback using wmic
  win32_VideoController for Windows systems without nvidia-smi on PATH
- New test_env_config_cuda.py: 16 test cases covering nvidia-smi,
  Windows path search, WMI fallback, and detect() integration
The stdin read loop blocks on sys.stdin, so the old running=False
flag approach never took effect. The process would hang until
forcibly killed (exit code null), triggering Aegis auto-diagnostics
unnecessarily. Now the signal handler emits final perf stats and
calls sys.exit(0) directly for a clean shutdown.
@solderzzc solderzzc merged commit 155eb45 into develop Mar 10, 2026
1 check passed
@solderzzc solderzzc deleted the feature/windows-deploy-bat branch March 10, 2026 19:13
@solderzzc solderzzc restored the feature/windows-deploy-bat branch March 10, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant