Skip to content

Conversation

@shahdyousefak
Copy link
Contributor

@shahdyousefak shahdyousefak commented Mar 11, 2025

resolves #912

Please ensure you've followed the checklist and provide all the required information before requesting a review.
If you do not have everything applicable to your PR, it will not be reviewed!
If you don't know what something is or if it applies to you, ask!

Don't delete below this line.


Required Information

  • I referenced the issue addressed in this PR. --> Currently, logging behavior is not properly differentiated between Unicorn and Pegasus. This leads to unnecessary and potentially sensitive logs appearing in production. The goal of this PR is to ensure that:
    Unicorn logs can be more verbose and include detailed error messages for debugging, including what may constitute PII-related logging, particularly when errors are thrown.
    Pegasus logs are minimal, avoiding unnecessary verbosity particularly when errors are thrown.

  • I described the changes made and how these address the issue. --> configured logging_utils.ts and logging_utils.py to handle PII logging separately for Unicorn and Pegasus.

  • I described how I tested these changes. --> verified that logs correctly identify whether the service is running in Unicorn (PII logging enabled) or Pegasus (PII logging disabled). toggled the

Coding/Commit Requirements

  • I followed applicable coding standards where appropriate (e.g., PEP8)
  • I have not committed any models or other large files.

New Component Checklist (mandatory for new microservices)

  • I added an entry to docker-compose.yml and build.yml.
  • I created A CI workflow under .github/workflows.
  • I have created a README.md file that describes what the component does and what it depends on (other microservices, ML models, etc.).

OR

  • I have not added a new component in this PR.

@shahdyousefak shahdyousefak requested review from jaydeepsingh25 and removed request for jaydeepsingh25 March 11, 2025 15:11
@jaydeepsingh25 jaydeepsingh25 merged commit 0664c3e into main Mar 28, 2025
70 checks passed
@jaydeepsingh25 jaydeepsingh25 deleted the 912-pii branch March 28, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better method for making sure jsonschema logging does not dump PII into logs

3 participants