-
Notifications
You must be signed in to change notification settings - Fork 7
912 pii #977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
912 pii #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeepsingh25
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #912
Please ensure you've followed the checklist and provide all the required information before requesting a review.
If you do not have everything applicable to your PR, it will not be reviewed!
If you don't know what something is or if it applies to you, ask!
Don't delete below this line.
Required Information
I referenced the issue addressed in this PR. --> Currently, logging behavior is not properly differentiated between Unicorn and Pegasus. This leads to unnecessary and potentially sensitive logs appearing in production. The goal of this PR is to ensure that:
Unicorn logs can be more verbose and include detailed error messages for debugging, including what may constitute PII-related logging, particularly when errors are thrown.
Pegasus logs are minimal, avoiding unnecessary verbosity particularly when errors are thrown.
I described the changes made and how these address the issue. --> configured logging_utils.ts and logging_utils.py to handle PII logging separately for Unicorn and Pegasus.
I described how I tested these changes. --> verified that logs correctly identify whether the service is running in Unicorn (PII logging enabled) or Pegasus (PII logging disabled). toggled the
Coding/Commit Requirements
New Component Checklist (mandatory for new microservices)
docker-compose.ymlandbuild.yml..github/workflows.README.mdfile that describes what the component does and what it depends on (other microservices, ML models, etc.).OR