iOS feedback form functionality fix #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeepsingh25
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This was one of the following bugs from the list of Safari-only bugs:
On the Feedback page, selecting "(Optional) I consent to the IMAGE project saving this request and the responses associated with it under the conditions described above" may cause the "open form" button to not work as intended. (I got your data has been recorded successfully instead).
I noticed that this was actually iOS only, so I had to find a solution.
Why was this happening
This was happening due to iOS devices not allowing open links on non-user registered actions.
https://stackoverflow.com/questions/67836871/why-open-link-is-not-working-inside-a-async-handler-on-ipad-safari
Weirdly, the "Close" action on the alert was not enough to be considered a user registered action. I believe this was lenient for Safari though which is why it worked.
How I fixed it
I fixed it by changing the logic from opening a new link to changing the existing one since iOS allows redirecting the user to a new site. This does obviously change the inherent logic from opening a new tab to redirection, but I hope that this solution is worthy enough to make the switch over.
Demo
Chrome
Before
Chrome-before.mov
After
Chrome-after.mov
Safari
Before
Safari-before.mov
After
Safari-after.mov
iOS
Before
iOS-before.1.mp4
After
iOS-after.mp4