fix(Hardware Support): Fix rare double input bug on Legion devices#564
Merged
fix(Hardware Support): Fix rare double input bug on Legion devices#564
Conversation
A somewhat rare event is described in #562 where the entire /dev directory seems to reset during startup after InputPlumber has already started gathering devices. During this event it is possible for the 'new' hidraw file descriptor for an already grabbed hidraw device to be detected before the cleanup has finished for that device. When this happens all of the evdev and iio devices end up on the original CompositeDevice and the hidraw all end up on a new composite device. This leads to duplicate device entries and input events. To resolve this until a better long-term solution is found, treat the hidraw devices as non-unique for now.
ShadowApex
approved these changes
Mar 27, 2026
Contributor
|
🎉 This PR is included in version 0.76.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A somewhat rare event is described in #562 where the entire /dev directory seems to reset during startup after InputPlumber has already started gathering devices. During this event it is possible for the 'new' hidraw file descriptor for an already grabbed hidraw device to be detected before the cleanup has finished for that device. When this happens all of the evdev and iio devices end up on the original CompositeDevice and the hidraw all end up on a new composite device. This leads to duplicate device entries and input events.
To resolve this until a better long-term solution is found, treat the hidraw devices as non-unique for now.