Skip to content

Fix GH Actions#174

Closed
AwesomeTornado wants to merge 1 commit into
feature/fix-gh-actionsfrom
main
Closed

Fix GH Actions#174
AwesomeTornado wants to merge 1 commit into
feature/fix-gh-actionsfrom
main

Conversation

@AwesomeTornado
Copy link
Copy Markdown
Collaborator

Closes #159
@elsevers

Notes

#160 broke gh actions, this PR should fix it again.

The issue is caused by the Makefile returning an error if there is nothing to delete when running make clean. To fix this, I used the --force flag.

Self-Review

  1. Are all files under 300 kB (if not, please carefully assess whether it is worth committing them)? Yes
  2. Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
  3. Do all Markdown files follow the CONTRIBUTING article template? Yes
  4. Do all links work in the material that the PR is adding? Yes
  5. Is the PR configured to close the correct issue(s)? Yes
  6. Did the PR fully address the Approach section of the issue(s) it is closing? Yes

Reviewer Instructions

Reviewers, please copy and paste a suitable review checklist into your review and answer all questions.

Appendix

This section should be the same for all PRs. Do not edit this section when creating a PR.

Review Checklists

Checklists maintained by the eLev lab for research repositories include:

Standard checklist

1. Are all files under 300 kB (if not, please carefully assess whether it is worth committing them)? **Yes or No**
2. Are all files named according to the appropriate [naming convention](https://github.com/Severson-Group/research-repo-template?tab=readme-ov-file#file-naming), i.e., dash-case, camelCase, snake case? **Yes or No**
3. Do all Markdown files follow the [CONTRIBUTING article template](https://github.com/Severson-Group/.github/blob/main/CONTRIBUTING.md#markdown-documentation-template)? **Yes or No**
4. Do all links work in the material that the PR is adding? **Yes or No**
5. Is the PR configured to close the correct issue(s)? **Yes or No**
6. Did the PR fully address the `Approach` section of the issue(s) it is closing? **Yes or No**

Please work on addressing any **No** items.

@AwesomeTornado AwesomeTornado requested a review from elsevers as a code owner May 20, 2026 13:00
@AwesomeTornado AwesomeTornado changed the title Add Version Switching (#160) Fix GH Actions May 20, 2026
@AwesomeTornado AwesomeTornado marked this pull request as draft May 20, 2026 13:01
@AwesomeTornado
Copy link
Copy Markdown
Collaborator Author

OOPS I did the pull request in the wrong direction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant