Update contributing guidelines to recommend either SVG or WEBP formats for images#9
Conversation
|
@AwesomeTornado, can we get your eyes on this and #8? I am worried that our knowledgebase repo size is getting out of hand, and this |
|
Yes I have used webp before, windows has good support for it. It would be a good idea to use webp here. |
|
@elsevers Do we want to mention light/dark mode support for svg's here? Or is that an issue for another day? |
|
Thanks! So, on dark vs light SVGs, I think this is only an issue for Sphinx documentation (i.e. docs.amdc.dev and emach.readthedocs.io), and not for our internal markdown docs, like the knowledgebase and repos, right? |
|
I see, yes that's correct. |
There was a problem hiding this comment.
@elsevers looks good!
- Are all files under 300 kB (if not, please carefully assess whether it is worth committing them)? Yes
- Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
- Do all Markdown files follow the CONTRIBUTING article template? Yes
- Do all links work in the material that the PR is adding? Yes
- Is the PR configured to close the correct issue(s)? Yes
- Did the PR fully address the Approach section of the issue(s) it is closing? Yes
noguchi-takahiro
left a comment
There was a problem hiding this comment.
@elsevers @AwesomeTornado I think it would be nice if there is an instruction of how to covert any images to .webp? I tried to do this using Power point, Windows Paint, and Photo but there is not options to export as webp.
| Whenever possible, contributors should use these two formats for images: | ||
|
|
||
| - **.svg**: for vectorized graphics (preferrably created in Inkscape) | ||
| - **.webp**: for rasterized graphics in place of `*.png` or `*.jpg`, as this offers much smaller file sizes (typically >45% smaller for same quality). |
There was a problem hiding this comment.
@AwesomeTornado do you have any recommended tool to convert png or jpg to webp using Windows? I could open .webp using Windows Photo app but there is no option to export:
|
Thanks @noguchi-takahiro and @AwesomeTornado, I agree that we need to provide instructions on how to create the images. I have just asked you to review https://github.com/Severson-Group/KnowledgeBase/pull/356, which seeks to add a new KB article on this. Once we have merged https://github.com/Severson-Group/KnowledgeBase/pull/356, I will revise this present PR to use it. |
|
@AwesomeTornado and @noguchi-takahiro, I have just updated this to now link to our new webp article. Can you give this PR another review? |
noguchi-takahiro
left a comment
There was a problem hiding this comment.
Thank you @elsevers. Looks good.
- Are all files under 300 kB (if not, please carefully assess whether it is worth committing them)? Yes
- Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
- Do all Markdown files follow the CONTRIBUTING article template? Yes
- Do all links work in the material that the PR is adding? Yes
- Is the PR configured to close the correct issue(s)? Yes
- Did the PR fully address the
Approachsection of the issue(s) it is closing? Yes
@AwesomeTornado could you review this PR?
Closes #8.
Notes
Take a look at my notes in #8 on the amazing file size reduction offered by WEBP files over PNG/JPG.
Self-Review
Approachsection of the issue(s) it is closing? YesReviewer Instructions
Reviewers, please copy and paste a suitable review checklist into your review and answer all questions.
Appendix
This section should be the same for all PRs. Do not edit this section when creating a PR.
Review Checklists
Checklists maintained by the eLev lab for research repositories include:
Standard checklist