fix(ci): resolve mypy failure and add wait_until default regression tests#70
Open
Copilot wants to merge 3 commits intofix/browser-navigate-wait-untilfrom
Open
fix(ci): resolve mypy failure and add wait_until default regression tests#70Copilot wants to merge 3 commits intofix/browser-navigate-wait-untilfrom
Copilot wants to merge 3 commits intofix/browser-navigate-wait-untilfrom
Conversation
6 tasks
Co-authored-by: OhYee <13498329+OhYee@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix default wait_until parameter from load to domcontentloaded
fix(ci): resolve mypy failure and add wait_until default regression tests
Mar 12, 2026
Member
|
@copilot merge conflict |
Co-authored-by: OhYee <13498329+OhYee@users.noreply.github.com>
Contributor
Author
Resolved in commit 7f603bb. The base branch had merged PR #69 which already added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI
make mypy-checkwas failing due to a type mismatch in the integration test, and thebrowser_navigate_back/browser_go_forwarddefault change lacked test coverage.Changes
Fix mypy error in
test_langchain_agui_integration.py: annotateinput_dataasAnyto satisfy langgraph'sPregel.astreamoverloads, which expect_InputAgentState | Command[Any] | None— not the inferreddict[str, list[dict[str, str]]]Add regression tests in
TestBrowserNavigationDefaultsto lock inwait_until="domcontentloaded"defaults for both nav functions. Usesargs_schema.model_fields(Pydantic v2) since@toolwraps the underlying function andinspect.signaturedoes not reach the original parameters:✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.