test(browser): lock in domcontentloaded defaults for browser_navigate_back/go_forward#69
Draft
Copilot wants to merge 2 commits intofix/browser-navigate-wait-untilfrom
Draft
test(browser): lock in domcontentloaded defaults for browser_navigate_back/go_forward#69Copilot wants to merge 2 commits intofix/browser-navigate-wait-untilfrom
Copilot wants to merge 2 commits intofix/browser-navigate-wait-untilfrom
Conversation
6 tasks
…back/go_forward Co-authored-by: OhYee <13498329+OhYee@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on default wait_until method in browser fix PR
test(browser): lock in domcontentloaded defaults for browser_navigate_back/go_forward
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No unit tests existed to guard the
wait_until="domcontentloaded"default introduced in #68 forbrowser_navigate_backandbrowser_go_forward, leaving the change vulnerable to silent regression.Changes
New
TestBrowserNavigationDefaultsclass intest_browser_toolset_error_handling.py— 4 tests assertingwait_until="domcontentloaded"andtimeout=Nonedefaults for both methods.Inspection approach —
inspect.signaturecannot introspectToolobjects produced by the@tooldecorator. Tests useTool.args_schema.model_fieldsinstead, which is the Pydantic model the decorator builds directly from the source function's signature:📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.