Skip to content

Conversation

@spholz
Copy link
Member

@spholz spholz commented Dec 9, 2025

This is usually done in add_to_mounts_list_and_increment_fs_mounted_count() if mounted_count == 1. But in this case, mounted_count is incremented manually and this function never called.

This fixes flushing filesystem data to disk with the sync command or via the periodically running "VFS Sync Task".

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Dec 9, 2025
@spholz
Copy link
Member Author

spholz commented Dec 9, 2025

This regressed in 01e1af7.

This is usually done in
add_to_mounts_list_and_increment_fs_mounted_count() if
mounted_count == 1. But in this case, mounted_count is incremented
manually and this function never called.

This fixes flushing filesystem data to disk with the `sync` command
or via the periodically running "VFS Sync Task".
@spholz spholz merged commit e2192d7 into SerenityOS:master Dec 9, 2025
13 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Dec 9, 2025
@spholz spholz deleted the kernel-fix-sync branch December 9, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant