Håndtering af maksimal filstørrelse i forbindelse med upload #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request test
I relation til issue Septima#159 er her et løsningsforslag
Med denne rettelse kan man styre pr. formular, hvor store filer man vil acceptere, der bliver uploadet
karstenpihl
reviewed
Apr 6, 2018
| /.settings | ||
| .DS_Store | ||
| *.db | ||
| js/formular - Copy.js |
Contributor
There was a problem hiding this comment.
Denne linje (js/formular - Copy.js) skal ikke være med i .gitignore. Det sikkert fordi du har haft en backup fil liggende. Kan du ikke fjerne den?
karstenpihl
reviewed
Apr 6, 2018
|
|
||
| fileupload: function (filename,id,orgfilename) { | ||
| removeInvalidFileNotice: function (id) { | ||
| var invalidFileDiv = jQuery('#'+id+'_invalidfile'); |
Contributor
There was a problem hiding this comment.
Dette kan laves mere simpel ved at erstatte de fire linjer med:
jQuery('#'+id+'_invalidfile').remove();
Den fjerner hvis der er nogen, ellers gør den ikke noget.
Contributor
Author
|
Hej Karsten. |
Contributor
|
Jeg kan ikke se dine rettelser så det kan godt være at du skal lave et nyt PR. |
Contributor
Author
|
Jeg lukker denne og laver et nyt med den opdaterede kode. |
karstenpihl
added a commit
that referenced
this pull request
Apr 10, 2018
Håndtering af maksimal filstørrelse i forbindelse med upload #161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Det kan være praktisk at kunne styre, hvor store filer der må uploades via en formular. Følgende rettelser til henholdsvis upload.jsp og formular.js (med dokumentation i readme.md) gør det muligt, at sætte en attribut (maxfilsize="<Mb som heltal>") på file tag´et i en formular.
Da jeg lokalt havde merged koden i relation til (Håndtering af parametre i forbindelse med NemLogin #160) sammen med denne rettelse/opdatering er det muligt at #160 blot skal ignoreres - ellers kommer funktionen paramHasValue muligvis ind 2 gange.