Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jun 21, 2025

This PR addresses the need for "better CI/CD testing using Helm charts" by implementing a comprehensive testing infrastructure that validates Helm charts across multiple environments and configurations.

What's Changed

🚀 New GitHub Actions Workflow (helm-ci.yml)

  • Chart Linting: Validates Helm chart syntax and best practices
  • Template Rendering: Tests chart templates with different configurations (local, GKE, AWS)
  • Schema Validation: Ensures Chart.yaml files have required fields
  • Integration Testing: Uses Kind clusters for actual deployment validation (PR only)
  • Multi-environment Support: Tests charts with various value combinations

🛠️ Local Developer Tools

  • Test Script (ops-scripts/test-helm-charts.sh): Easy-to-use local testing
  • Modular Testing: Run specific test types (lint, template, schema, config, deps)
  • Graceful Error Handling: Properly handles known issues with informative warnings
  • CI Simulation: Developers can run the same tests locally as CI

📚 Enhanced Documentation

  • Comprehensive Guide (docs/helm-testing.md): Complete testing documentation
  • Updated README: Added testing section with quick start instructions
  • Best Practices: Guidelines for chart development and troubleshooting
  • Known Issues: Documented workarounds for current limitations

🔧 Improved Maven Workflow

  • Timeout Protection: Prevents hanging integration tests
  • Better Error Reporting: Enhanced warnings and error messages

Example Usage

# Test all charts locally
./ops-scripts/test-helm-charts.sh

# Run specific tests
./ops-scripts/test-helm-charts.sh lint      # Lint charts only
./ops-scripts/test-helm-charts.sh template  # Test rendering
./ops-scripts/test-helm-charts.sh config    # Test configurations

Validation Results

sentrius-chart-launcher: Full validation passes
⚠️ sentrius-chart: Lints with known ingress template issue (handled gracefully)
Template Rendering: All working charts render correctly
Schema Validation: All Chart.yaml files properly structured
Integration Testing: Kind cluster deployment validation ready

Impact

  • Prevents Deployment Issues: Automated validation catches problems before deployment
  • Faster Development: Local testing reduces iteration time
  • Better Quality: Multiple validation layers ensure chart reliability
  • Clear Documentation: Developers have comprehensive testing guidance

The implementation maintains minimal changes to existing code while providing robust testing infrastructure that scales with the project's needs.

Fixes #46.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • repository.jboss.org
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -classpath /usr/share/apache-maven-3.9.9/boot/plexus-classworlds-2.8.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.9/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.9 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.9/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/Sentrius/Sentrius org.codehaus.plexus.classworlds.launcher.Launcher -q test -Dmaven.test.skip=false (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits June 21, 2025 13:21
Co-authored-by: phrocker <1781585+phrocker@users.noreply.github.com>
Co-authored-by: phrocker <1781585+phrocker@users.noreply.github.com>
Copilot AI changed the title [WIP] deploy helm charts for CICD testing Implement comprehensive Helm chart CI/CD testing for better deployment validation Jun 21, 2025
Copilot AI requested a review from phrocker June 21, 2025 13:31
@phrocker phrocker marked this pull request as ready for review June 22, 2025 17:09
@phrocker phrocker merged commit 5b9ff1f into main Jun 22, 2025
8 checks passed
@phrocker phrocker deleted the copilot/fix-46 branch July 31, 2025 13:55
phrocker added a commit that referenced this pull request Nov 8, 2025
…ecall (#47)

* Initial plan

* Add memory lookup verbs to agent plan execution

- Added lookup_agent_memory verb for text-based memory search
- Added search_agent_memory_semantic verb for vector-based semantic search
- Both verbs integrate with existing VectorAgentMemoryStore API
- Support filtering by agentId, markings, and limit parameters

Co-authored-by: phrocker <1781585+phrocker@users.noreply.github.com>

* Add tests for memory lookup verbs and fix parameter handling

- Added comprehensive tests for lookup_agent_memory verb
- Added tests for search_agent_memory_semantic verb
- Fixed parameter extraction to handle NullPointerExceptions from getExecutionArgument
- All tests passing (21 tests, 0 failures, 0 errors)

Co-authored-by: phrocker <1781585+phrocker@users.noreply.github.com>

* Improve memory lookup verb descriptions for better LLM guidance

- Enhanced lookup_agent_memory description with explicit examples for cross-session recall
- Added guidance to always check memory before asking users to repeat information
- Updated search_agent_memory_semantic with clearer use cases for conceptual searches
- Added instructions to chat-helper.yaml to proactively use memory lookup verbs
- Examples now include user personal info scenarios (names, preferences)

Co-authored-by: phrocker <1781585+phrocker@users.noreply.github.com>

* fixup

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: phrocker <1781585+phrocker@users.noreply.github.com>
Co-authored-by: Marc Parisi <phrocker@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deploy helm charts for CICD testing

2 participants