Skip to content

Adapt SDK to wait for loading async function in chrome #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcholic merged 1 commit into from
Dec 25, 2025
Merged

Adapt SDK to wait for loading async function in chrome #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions sentience/snapshot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
Snapshot functionality - calls window.sentience.snapshot() or server-side API
"""

import json
from typing import Any, Dict, Optional
from typing import Any

import requests

Expand Down Expand Up @@ -53,6 +52,31 @@ def _snapshot_via_extension(
if not browser.page:
raise RuntimeError("Browser not started. Call browser.start() first.")

# CRITICAL: Wait for extension injection to complete (CSP-resistant architecture)
# The new architecture loads injected_api.js asynchronously, so window.sentience
# may not be immediately available after page load
try:
browser.page.wait_for_function(
"typeof window.sentience !== 'undefined'", timeout=5000 # 5 second timeout
)
except Exception as e:
# Gather diagnostics if wait fails
try:
diag = browser.page.evaluate(
"""() => ({
sentience_defined: typeof window.sentience !== 'undefined',
extension_id: document.documentElement.dataset.sentienceExtensionId || 'not set',
url: window.location.href
})"""
)
except Exception:
diag = {"error": "Could not gather diagnostics"}

raise RuntimeError(
f"Sentience extension failed to inject window.sentience API. "
f"Is the extension loaded? Diagnostics: {diag}"
) from e

# Build options
options: dict[str, Any] = {}
if screenshot is not None:
Expand Down Expand Up @@ -93,6 +117,15 @@ def _snapshot_via_api(
if not browser.api_url:
raise ValueError("API URL required for server-side processing")

# CRITICAL: Wait for extension injection to complete (CSP-resistant architecture)
# Even for API mode, we need the extension to collect raw data locally
try:
browser.page.wait_for_function("typeof window.sentience !== 'undefined'", timeout=5000)
except Exception as e:
raise RuntimeError(
"Sentience extension failed to inject. Cannot collect raw data for API processing."
) from e

# Step 1: Get raw data from local extension (always happens locally)
raw_options: dict[str, Any] = {}
if screenshot is not None:
Expand Down