[Java] JSpecify annotations for LoadableComponent , SlowLoadableComponent#16798
[Java] JSpecify annotations for LoadableComponent , SlowLoadableComponent#16798asolntsev merged 6 commits intoSeleniumHQ:trunkfrom
LoadableComponent , SlowLoadableComponent#16798Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||||||
|
Thank you, @mk868 for this code suggestion. The support packages contain example code that many users find helpful, but they do not necessarily represent After reviewing the change, unless it is a critical fix or a feature that is needed for Selenium We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks. |
PR Code Suggestions ✨No code suggestions found for the PR. |
all requested changed have been implemented
User description
🔗 Related Issues
Related #14291
💥 What does this PR do?
JSpecify annotations added to the:
org.openqa.selenium.support.ui.SlowLoadableComponentorg.openqa.selenium.support.ui.LoadableComponent🔧 Implementation Notes
💡 Additional Considerations
I know that the future of the support package is still unknown/undecided.
But there is an user-facing API, so it would be nice to have nullability annotations there.
Especially for running a NullAway analysis for the whole project.
🔄 Types of changes
PR Type
Enhancement
Description
Add JSpecify
@NullMarkedannotations to LoadableComponentAdd JSpecify
@NullMarkedannotations to SlowLoadableComponentAdd jspecify dependency to BUILD.bazel configuration
Diagram Walkthrough
File Walkthrough
LoadableComponent.java
Add JSpecify nullability annotation to LoadableComponentjava/src/org/openqa/selenium/support/ui/LoadableComponent.java
org.jspecify.annotations.NullMarked@NullMarkedannotation to class declarationSlowLoadableComponent.java
Add JSpecify nullability annotation to SlowLoadableComponentjava/src/org/openqa/selenium/support/ui/SlowLoadableComponent.java
org.jspecify.annotations.NullMarked@NullMarkedannotation to class declarationBUILD.bazel
Add jspecify dependency to BUILD configurationjava/src/org/openqa/selenium/support/ui/BUILD.bazel
org.jspecify:jspecifyartifact dependency to components targetSlowLoadableComponent