Skip to content

Test: Control recording over session capability only #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VietND96 merged 1 commit into from
May 22, 2026
Merged

Test: Control recording over session capability only #3136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/helm-chart-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
os: ubuntu-22.04
check-records-output: true
test-strategy: playwright_connect_grid
- k8s-version: 'v1.33.6'
- k8s-version: 'v1.32.10'
cluster: 'minikube'
helm-version: 'v3.18.6'
docker-version: '28.5.2'
Expand Down
9 changes: 3 additions & 6 deletions tests/SeleniumTests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,7 @@ def setUp(self):
options.enable_downloads = SELENIUM_ENABLE_MANAGED_DOWNLOADS
if not SELENIUM_ENABLE_MANAGED_DOWNLOADS:
options.add_argument('disable-features=DownloadBubble,DownloadBubbleV2')
if TEST_ADD_CAPS_RECORD_VIDEO:
options.set_capability('se:recordVideo', True)
options.set_capability('se:recordVideo', True)
Copy link
Copy Markdown
Contributor

@qodo-code-review qodo-code-review Bot May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Record-video flag ignored 🐞 Bug ≡ Correctness

tests/SeleniumTests/__init__.py still reads TEST_ADD_CAPS_RECORD_VIDEO but now unconditionally
sets se:recordVideo=true, so TEST_ADD_CAPS_RECORD_VIDEO=false no longer changes behavior. This
breaks Makefile/docker-compose flows that explicitly set TEST_ADD_CAPS_RECORD_VIDEO=false (e.g.,
test_video_dynamic_name) and forces video recording overhead even when intentionally disabled.
Agent Prompt 
## Issue description
`TEST_ADD_CAPS_RECORD_VIDEO` is still read from the environment but is no longer used to control whether the test client sends `se:recordVideo`. Several CI/test entrypoints still set/pass this env var expecting it to change behavior.

## Issue Context
- The test module still defines `TEST_ADD_CAPS_RECORD_VIDEO`, but the capability is always set.
- The Makefile and docker-compose test harness still pass `TEST_ADD_CAPS_RECORD_VIDEO`, including a target that explicitly sets it to `false`.

## Fix Focus Areas
Choose one consistent direction:
1) **Keep the toggle**: restore the `if TEST_ADD_CAPS_RECORD_VIDEO:` guard around `options.set_capability('se:recordVideo', True)` for Chrome/Edge/Firefox.
2) **Remove the toggle** (if the new behavior is intended): delete `TEST_ADD_CAPS_RECORD_VIDEO` parsing + remove it from docker-compose/Makefile targets (including `test_video_dynamic_name`) so the repo doesn’t advertise a knob that does nothing.

### Fix Focus Areas (paths/lines)
- tests/SeleniumTests/__init__.py[33-35]
- tests/SeleniumTests/__init__.py[155-165]
- tests/SeleniumTests/__init__.py[216-224]
- tests/SeleniumTests/__init__.py[266-280]
- Makefile[1100-1102]
- tests/docker-compose-v3-test-video.yml[78-88]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

if TEST_RETAIN_ON_FAILURE:
options.set_capability('se:retainOnFailure', True)
if TEST_CUSTOM_SPECIFIC_NAME:
Expand Down Expand Up @@ -221,8 +220,7 @@ def setUp(self):
options.enable_downloads = SELENIUM_ENABLE_MANAGED_DOWNLOADS
if not SELENIUM_ENABLE_MANAGED_DOWNLOADS:
options.add_argument('disable-features=DownloadBubble,DownloadBubbleV2')
if TEST_ADD_CAPS_RECORD_VIDEO:
options.set_capability('se:recordVideo', True)
options.set_capability('se:recordVideo', True)
if TEST_RETAIN_ON_FAILURE:
options.set_capability('se:retainOnFailure', True)
if TEST_CUSTOM_SPECIFIC_NAME:
Expand Down Expand Up @@ -277,8 +275,7 @@ def setUp(self):
profile.set_preference('intl.accept_languages', 'vi-VN,vi')
profile.set_preference('intl.locale.requested', 'vi-VN,vi')
options.profile = profile
if TEST_ADD_CAPS_RECORD_VIDEO:
options.set_capability('se:recordVideo', True)
options.set_capability('se:recordVideo', True)
if TEST_RETAIN_ON_FAILURE:
options.set_capability('se:retainOnFailure', True)
if TEST_CUSTOM_SPECIFIC_NAME:
Expand Down
2 changes: 0 additions & 2 deletions tests/docker-compose-v3-dev-arm64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ services:
- SE_EVENT_BUS_HOST=selenium-hub
- SE_VNC_NO_PASSWORD=true
- SE_NODE_ENABLE_MANAGED_DOWNLOADS=true
- SE_RECORD_VIDEO=true

firefox:
deploy:
Expand All @@ -33,7 +32,6 @@ services:
- SE_EVENT_BUS_HOST=selenium-hub
- SE_VNC_NO_PASSWORD=true
- SE_NODE_ENABLE_MANAGED_DOWNLOADS=true
- SE_RECORD_VIDEO=true

selenium-hub:
image: selenium/hub:4.43.0-20260404
Expand Down
2 changes: 0 additions & 2 deletions tests/docker-compose-v3-event-driven-arm64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ services:
- /tmp/videos:/videos
environment:
- SE_EVENT_BUS_HOST=selenium-hub
- SE_RECORD_VIDEO=true
- SE_RETAIN_ON_FAILURE=true
# Remote name and destination path to upload
- SE_UPLOAD_DESTINATION_PREFIX=myftp://ftp/seluser
Expand All @@ -62,7 +61,6 @@ services:
- /tmp/videos:/videos
environment:
- SE_EVENT_BUS_HOST=selenium-hub
- SE_RECORD_VIDEO=true
- SE_RETAIN_ON_FAILURE=true
# Remote name and destination path to upload
- SE_UPLOAD_DESTINATION_PREFIX=myftp://ftp/seluser
Expand Down
1 change: 0 additions & 1 deletion tests/docker-compose-v3-event-driven-standalone-arm64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ services:
- /tmp/videos:/videos
environment:
- SE_VIDEO_RECORD_STANDALONE=true
- SE_RECORD_VIDEO=true
- SE_VIDEO_UPLOAD_ENABLED=true
- SE_DYNAMIC_OVERRIDE_MAX_SESSIONS=true
- SE_DYNAMIC_MAX_SESSIONS=4
Expand Down
4 changes: 0 additions & 4 deletions tests/docker-compose-v3-get-started-arm64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ services:
- /tmp/videos:/videos
environment:
- SE_EVENT_BUS_HOST=selenium-hub
- SE_RECORD_VIDEO=true
- SE_VIDEO_FILE_NAME=auto
- SE_NODE_GRID_URL=http://selenium-hub:4444

firefox:
Expand All @@ -30,8 +28,6 @@ services:
- /tmp/videos:/videos
environment:
- SE_EVENT_BUS_HOST=selenium-hub
- SE_RECORD_VIDEO=true
- SE_VIDEO_FILE_NAME=auto
- SE_NODE_GRID_URL=http://selenium-hub:4444

selenium-hub:
Expand Down
6 changes: 0 additions & 6 deletions tests/docker-compose-v3-test-parallel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ services:
- SE_DRAIN_AFTER_SESSION_COUNT=4
- SE_ENABLE_TLS=true
- SE_JAVA_OPTS=-Dwebdriver.httpclient.readTimeout=${REQUEST_TIMEOUT}
- SE_RECORD_VIDEO=true
- SE_VIDEO_FILE_NAME=auto
- SE_SERVER_PROTOCOL=https
- SE_NODE_GRID_URL=https://selenium-hub:4444
- SE_NODE_STEREOTYPE_EXTRA={"myApp:version":"beta","myApp:publish":"public"}
Expand Down Expand Up @@ -65,8 +63,6 @@ services:
- SE_DRAIN_AFTER_SESSION_COUNT=2
- SE_ENABLE_TLS=true
- SE_JAVA_OPTS=-Dwebdriver.httpclient.readTimeout=${REQUEST_TIMEOUT}
- SE_RECORD_VIDEO=true
- SE_VIDEO_FILE_NAME=auto
- SE_SERVER_PROTOCOL=https
- SE_NODE_GRID_URL=https://selenium-hub:4444
- SE_NODE_STEREOTYPE_EXTRA={"myApp:version":"beta","myApp:publish":"public"}
Expand Down Expand Up @@ -97,8 +93,6 @@ services:
- SE_DRAIN_AFTER_SESSION_COUNT=3
- SE_ENABLE_TLS=true
- SE_JAVA_OPTS=-Dwebdriver.httpclient.readTimeout=${REQUEST_TIMEOUT}
- SE_RECORD_VIDEO=true
- SE_VIDEO_FILE_NAME=auto
- SE_SERVER_PROTOCOL=https
- SE_NODE_GRID_URL=https://selenium-hub:4444
- SE_NODE_STEREOTYPE_EXTRA={"myApp:version":"beta","myApp:publish":"public"}
Expand Down
Loading