Skip to content

Conversation

@hrishabhayush
Copy link
Collaborator

@hrishabhayush hrishabhayush commented Feb 7, 2025

Musical Charts creates an Automated Market Maker (AMM) where users must listen to dynamically generated violin music—derived from real-time market data—before making trade decisions. Each transaction triggers a fresh melody, creating an engaging and intuitive trading experience.

This project has 3 files under the src directory - which holds the core logic to creating an AMM with SRC20 tokens. The description of those three files are:

  • Riff.sol - creates an Automated Market Maker and contains the shielded swaps logic
  • SRC20.sol - holds the logic to creation of shielded tokens and it can be thought of as abstraction of its counterpart ERC20.sol smart contract
  • ViolinCoin.sol - creation of specific tokens for our musical charts project that allows mint, transfer, etc.

We have all the test under test directory that contains Riff.t.sol that tests swap mechanics, price revelation thresholds, user's listening permissions, and liquidity pool invariants.

Copy link
Collaborator

@ssolit ssolit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will likely ask you to update this file if/when we have a version update

@hrishabhayush
Copy link
Collaborator Author

Updated the logic for the smart contract and test cases, however the test_PriceUp is failing because of this line assertLt(swapperQuoteT0, quoteAsset.balanceOf());

@hrishabhayush
Copy link
Collaborator Author

The failing test case is now resolved and this is ready for review!

@lyronctk lyronctk requested review from lyronctk February 11, 2025 15:22
Copy link
Contributor

@lyronctk lyronctk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ameya-deshmukh ameya-deshmukh self-requested a review February 11, 2025 17:00
Copy link
Collaborator

@ameya-deshmukh ameya-deshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@ameya-deshmukh ameya-deshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ameya-deshmukh ameya-deshmukh changed the title Musical Charts Riff Feb 11, 2025
Copy link
Collaborator

@ameya-deshmukh ameya-deshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lyronctk lyronctk changed the title Riff RIFF: Listen to a bonding curve Feb 11, 2025
@lyronctk lyronctk added this pull request to the merge queue Feb 11, 2025
Merged via the queue into SeismicSystems:main with commit 73e2acc Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants