Open
Conversation
thypon
commented
Mar 28, 2026
- Migrate sf::VideoMode to use sf::Vector2u for size (width/height merged into .size.x/.size.y)
- Replace sf::Event::KeyPressed/KeyReleased union access with evt.getIfsf::Event::KeyPressed/KeyReleased()
- Add sf::Keyboard::Key:: prefix to all keyboard key enum values
- Replace sf::Style::Fullscreen with sf::State::Fullscreen and add state parameter to window.create()
- Change sf::Image::create() to sf::Image::resize() with Vector2u parameter
- Update collision detection and rect operations to use Vector2f variants
- Update audio system to use new SFML3 streaming and buffer APIs
- Replace deprecated sf::Mouse::getPosition with sf::Mouse::getGlobalPosition
- Migrate sf::VideoMode to use sf::Vector2u for size (width/height merged into .size.x/.size.y) - Replace sf::Event::KeyPressed/KeyReleased union access with evt.getIf<sf::Event::KeyPressed/KeyReleased>() - Add sf::Keyboard::Key:: prefix to all keyboard key enum values - Replace sf::Style::Fullscreen with sf::State::Fullscreen and add state parameter to window.create() - Change sf::Image::create() to sf::Image::resize() with Vector2u parameter - Update collision detection and rect operations to use Vector2f variants - Update audio system to use new SFML3 streaming and buffer APIs - Replace deprecated sf::Mouse::getPosition with sf::Mouse::getGlobalPosition
Member
|
Whoa, that’s a large step. I will try to take a look next weekend, but at the first glance it actually looks fine. I have not tried to compile it yet, though. Thank you so far. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.