Skip to content

Conversation

@manmath
Copy link

@manmath manmath commented Jul 1, 2016

Hi @visay,

Please review my change.

Thanks,
Man

@visay
Copy link
Collaborator

visay commented Oct 18, 2016

@Sebobo what do you think about this merge request? for me, it's fine as we already have dockertypo3 default port to 80 and require each developer machine to not have a webserver running. Usually we uninstalled webserver because there is no need anymore with docker. But if some users still want to keep their local installed webserver, they need to manage the service manually when they want to start docker.

@Nguonchhay
Copy link

@visay I think it is not give much value by set default port to 80. It is only take extra work for developer. Sometimes they still want to keep their existing environment without conflict with docker. (It is just my opinion).

@visay
Copy link
Collaborator

visay commented Apr 21, 2017

I'm planning on making it configurable on runtime. So will need to adjust this pull request a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants