Skip to content

Fix Overlapping TTS Playback when different characters are speaking in turns#61

Open
JoeyBelvar wants to merge 3 commits into
Sebane1:masterfrom
JoeyBelvar:codex/mediaobject-done-playing-null-safety
Open

Fix Overlapping TTS Playback when different characters are speaking in turns#61
JoeyBelvar wants to merge 3 commits into
Sebane1:masterfrom
JoeyBelvar:codex/mediaobject-done-playing-null-safety

Conversation

@JoeyBelvar
Copy link
Copy Markdown
Contributor

@JoeyBelvar JoeyBelvar commented May 15, 2026

Intent: stop outgoing NPC dialogue audio when the talk line changes, especially when skipping from one speaker to another.

  • Stops the active NPC speech object before _currentSpeechObject is replaced by the next speaker.
  • Keeps existing request cancellation behavior so stale relay responses cannot play after dialogue advances.
  • Wires Core media diagnostics into the plugin log under the existing [NPC TTS] logging style.
  • Adds maintainer comments around the turn-swap stop path to explain why stop must happen before replacement.

Depends on : Sebane1/RoleplayingVoiceCore#8

@JoeyBelvar JoeyBelvar force-pushed the codex/mediaobject-done-playing-null-safety branch from 0dfdb21 to ba2adf3 Compare May 16, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant