fix: resolve cron scheduler goroutine leak and modernize usage#831
Open
CybotTM wants to merge 2 commits intoSeagate:mainfrom
Open
fix: resolve cron scheduler goroutine leak and modernize usage#831CybotTM wants to merge 2 commits intoSeagate:mainfrom
CybotTM wants to merge 2 commits intoSeagate:mainfrom
Conversation
…duler - Store cron.Cron instance so it can be stopped during FileCache shutdown - Initialize stopAsyncUpload channel (was nil, making select cases dead code) - Call cron.Stop() in FileCache.Stop() and wait for graceful shutdown - Replace hand-rolled Schedule.Next() loop with ScheduleWithPrev.Prev() and WithRunImmediately() for cleaner active-window detection
CybotTM
requested review from
Dabnsky,
Ferelith-maker,
brayan-trejo,
foodprocessor and
jfantinhardesty
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*cron.Croninstance and callStop()during shutdownValidateSpec()instead of customisValidCronExpression()Context
Found during netresearch/go-cron dependent analysis. The cron scheduler was created in
SetupScheduler()but never stored as a struct field, making it impossible to stop — causing a goroutine leak for the lifetime of the process.Changes
component/azstorage/azautolog.go*cron.Cronas struct field, callStop()inStop()methodcomponent/azstorage/azautolog.goisValidCronExpression()withcron.ValidateSpec()go.mod/go.sumTest plan
Stop()is called during component shutdown