-
-
Notifications
You must be signed in to change notification settings - Fork 661
fix: allow LEFT JOIN to produce None for nested models #2845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
e65735d to
5b37411
Compare
b8e7b8b to
d70adc5
Compare
|
the test case failed, any ideas? my current understanding: if the parent object is |
Looking into this |
2f9d3d9 to
5773b30
Compare
94eddc0 to
c940b31
Compare
c940b31 to
58d4cca
Compare
|
@tyt2y3 As to your understanding - correct, that's what it does. |
|
Awesome! |
PR Info
Bug Fixes
When using LEFT JOIN with a nested
Option<Model>, code tried to read the missingrelated row as if it were always present. This caused a type error instead of simply
returning
None.This change makes nested optional models behave normal by treating
all-null fields as a missing record.
Testing
Added test that validates the fix.