-
Notifications
You must be signed in to change notification settings - Fork 0
Responsiveness improvements #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| CLAUDE.md |
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,7 +45,7 @@ export function Markdown({ content, className }: MarkdownProps) { | |
| ref={containerRef} | ||
| className={cn( | ||
| "markdown-content prose prose-sm dark:prose-invert", | ||
| "max-w-[calc(100vw-8rem)] sm:max-w-[500px] md:max-w-[600px] lg:max-w-[700px]", | ||
| "max-w-none", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. removing max-width constraints could make markdown content too wide on large screens, reducing readability - consider keeping a reasonable max-width (e.g., Prompt To Fix With AIThis is a comment left during a code review.
Path: ui/src/components/Markdown/Markdown.tsx
Line: 48
Comment:
removing max-width constraints could make markdown content too wide on large screens, reducing readability - consider keeping a reasonable max-width (e.g., `max-w-prose` or `max-w-4xl`) for better typography
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
||
| "[&_pre]:overflow-x-auto", | ||
| className | ||
| )} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,7 +75,7 @@ function StreamingMarkdownComponent({ content, isStreaming, className }: Streami | |
| <div | ||
| className={cn( | ||
| "markdown-content prose prose-sm dark:prose-invert", | ||
| "max-w-[calc(100vw-8rem)] sm:max-w-[500px] md:max-w-[600px] lg:max-w-[700px]", | ||
| "max-w-none", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. removing max-width constraints could make markdown content too wide on large screens, reducing readability - consider keeping a reasonable max-width (e.g., Prompt To Fix With AIThis is a comment left during a code review.
Path: ui/src/components/StreamingMarkdown/StreamingMarkdown.tsx
Line: 78
Comment:
removing max-width constraints could make markdown content too wide on large screens, reducing readability - consider keeping a reasonable max-width (e.g., `max-w-prose` or `max-w-4xl`) for better typography
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
||
| "[&_pre]:overflow-x-auto", | ||
| className | ||
| )} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed hover preview functionality - users could previously preview demos by hovering over tabs without clicking
Prompt To Fix With AI