Skip to content

Phpunit 12 and 13 compatibility #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bilge merged 15 commits into from
Mar 10, 2026
Merged

Phpunit 12 and 13 compatibility #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
62f45d6
Support PHPUnit 12 in dependencies and CI configuration
Mar 10, 2026
9154032
Update CI configuration to test against PHP 8.4 and 8.5
Mar 10, 2026
da7a161
Update testDataProvider method to accept a string parameter
Mar 10, 2026
b59204c
Fix output formatting in data provider test
Mar 10, 2026
ef3d0e3
Improve output formatting in data provider test
Mar 10, 2026
fc1078c
Fix ANSI escape code usage in data provider test output
Mar 10, 2026
fa4f0ab
Improve formatting of data provider test output
Mar 10, 2026
55dc31c
Improve formatting of data provider test output
Mar 10, 2026
8389a77
Refine data provider test output formatting
Mar 10, 2026
db7867b
Update CI configuration to include PHP 13 in test matrix
Mar 10, 2026
990e69f
Raise minimum PHP version to 8.3 and add PHPUnit 13 support in compos…
Mar 10, 2026
cab3b6d
Exclude PHP 8.3 with PHPUnit 13 from CI test matrix
Mar 10, 2026
bbb9df2
Lower minimum PHP version to 8.2 and adjust CI test matrix accordingly
Mar 10, 2026
3679805
Lower minimum PHP version to 8.1 and update CI test matrix accordingly
Mar 10, 2026
c52e456
Exclude PHPUnit 11 and 12 with PHP 8.1 from CI test matrix
Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/Tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,26 @@ jobs:
- 8.1
- 8.2
- 8.3
- 8.4
- 8.5
phpunit:
- 10
- 11
- 12
- 13
exclude:
- php: 8.1
phpunit: 11
- php: 8.1
phpunit: 12
- php: 8.1
phpunit: 13
- php: 8.2
phpunit: 12
- php: 8.2
phpunit: 13
- php: 8.3
phpunit: 13

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
],
"require": {
"php": ">=8.1",
"phpunit/phpunit": "^10.5.28|^11.2.8"
"phpunit/phpunit": "^10.5.28|^11.2.8|^12|^13"
},
"autoload": {
"psr-4": {
Expand Down
3 changes: 1 addition & 2 deletions test/CapabilitiesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,7 @@ public function testMixedSeverities(): void
}

#[DataProvider('provideData')]

public function testDataProvider(): void
public function testDataProvider(string $data): void
{
self::assertTrue(true);
}
Expand Down
4 changes: 2 additions & 2 deletions test/config/test dp args.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ PHPUnit %s
Runtime: %s
Configuration: %s

50% . ScriptFUSIONTest\Pip\CapabilitiesTest::testDataProvider with data set "foo" (%d ms)
100% . ScriptFUSIONTest\Pip\CapabilitiesTest::testDataProvider with data set #0 (%d ms)
50% . ScriptFUSIONTest\Pip\CapabilitiesTest::testDataProvider%swith data%s (%d ms)
Copy link
Member

@Bilge Bilge Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests should be as precise as possible. This is very lax, having now completely omitted the data set names.

  1. Why is the first %s needed?
  2. Why were data set names replaced with the second %s?

Copy link
Contributor Author

@ireneperezddc1 ireneperezddc1 Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By using phpunit 10/11 the data set and data is detailed always after the test: "with data set '@name or data set'|'#index of dataset' and then the ('data used'), but from Phpunit 12, the dataset is specified just after the test name: testDataProvider@foo|testDataProvider#0 with data ('data'), so, if I wanted to support both I tried by using EXPECTREGEX, but I can't found a way to have it working

100% . ScriptFUSIONTest\Pip\CapabilitiesTest::testDataProvider%swith data%s (%d ms)


Time: %s
Expand Down
4 changes: 2 additions & 2 deletions test/functional/data provider.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ PHPUnit %s
Runtime: %s
Configuration: %s

50% . ScriptFUSIONTest\Pip\CapabilitiesTest::testDataProvider with data set "foo" ('bar') (%d ms)
100% . ScriptFUSIONTest\Pip\CapabilitiesTest::testDataProvider with data set #0 ('baz') (%d ms)
50% . ScriptFUSIONTest\Pip\CapabilitiesTest::testDataProvider%swith data%s('bar') (%d ms)
100% . ScriptFUSIONTest\Pip\CapabilitiesTest::testDataProvider%swith data%s('baz') (%d ms)


Time: %s
Expand Down
10 changes: 5 additions & 5 deletions test/functional/success after failure.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,22 @@ PHPUnit %s
Runtime: %s
Configuration: %s

25% . ScriptFUSIONTest\Pip\CapabilitiesTest::testSuccessAfterFailure with data set #0 (true) (%d ms)
50% F ScriptFUSIONTest\Pip\CapabilitiesTest::testSuccessAfterFailure with data set #1 (false) (%d ms)
25% . ScriptFUSIONTest\Pip\CapabilitiesTest::testSuccessAfterFailure%swith data%s(true) (%d ms)
50% F ScriptFUSIONTest\Pip\CapabilitiesTest::testSuccessAfterFailure%swith data%s(false) (%d ms)

Failed asserting that false is true.

%s%eCapabilitiesTest.php:%d

75% ! ScriptFUSIONTest\Pip\CapabilitiesTest::testSuccessAfterFailure with data set #2 (true) (%d ms)
100% ! ScriptFUSIONTest\Pip\CapabilitiesTest::testSuccessAfterFailure with data set #3 (true) (%d ms)
75% ! ScriptFUSIONTest\Pip\CapabilitiesTest::testSuccessAfterFailure%swith data%s(true) (%d ms)
100% ! ScriptFUSIONTest\Pip\CapabilitiesTest::testSuccessAfterFailure%swith data%s(true) (%d ms)


Time: %s

There was 1 failure:

1) ScriptFUSIONTest\Pip\CapabilitiesTest::testSuccessAfterFailure with data set #1 (false)
1) ScriptFUSIONTest\Pip\CapabilitiesTest::testSuccessAfterFailure%swith data%s(false)
Failed asserting that false is true.

%s%eCapabilitiesTest.php:%d
Expand Down