Improve behaviour of user interactions wrt TTS queue#862
Merged
davecraig merged 6 commits intoScottish-Tech-Army:mainfrom Mar 20, 2026
Merged
Improve behaviour of user interactions wrt TTS queue#862davecraig merged 6 commits intoScottish-Tech-Army:mainfrom
davecraig merged 6 commits intoScottish-Tech-Army:mainfrom
Conversation
This is a longstanding easy to fix bug. We now report "No nearby markers" rather than stay silent.
My location does reverse geocoding to find the users current location. This can involve network and take a few seconds. This change immediately plays the Earcon so that the user has feedback that their action had an effect.
Waiting for "Around Me" or "Ahead of Me" audio to finish can take a while. On iOS tapping the button again would stop it immediately, and this change takes a similar approach. As well as some adding job cancellation in the SoundscapeService functions a new awaitHandle call has been added down into the C++ code. This waits for the passed in handle to be no longer queued - either because it has played out, or it has been cleared. In this way each calloutJob only completes when the callout has been fully read out.
The TTS isn't cleared and so is read out in full when each skip is done. This backs up the audio queue. This change means that only when the route player automatically moves to the next waypoint is it guaranteed to be read out. User initiated skipping clears the TTS queue and so avoids endless output.
Although cancelCallout was successfully cancelling other hear my surroundings calls it wasn't over-riding auto callouts. This changes ensures that it always takes precedent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.