fix(routing): force tool_choice=required in OneStepForwardReasoner to eliminate format drift#1347
Merged
Merged
Conversation
Contributor
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
… eliminate format drift
Contributor
Author
|
@Oceania2018 Ready for review. Thank you! |
Oceania2018
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to format drift, LLMs may complete with finishReason=stop and return free text or JSON in Content instead of a structured function call, causing instruction parsing failures in OneStepForwardReasoner.
tool_choice=requiredas a scoped state around the single completion call in OneStepForwardReasoner.GetNextInstruction, ensuring the LLM always returns the instruction as a function call and the state is cleaned up immediately aftertool_choice=requiredguarantees a function call response