-
-
Notifications
You must be signed in to change notification settings - Fork 594
refine parameters #1248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refine parameters #1248
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||||
PR Type
Enhancement
Description
Add fallback to return current value when model parameter not found
Refactor reasoning effort level parsing logic for clarity
Move state retrieval before null check in ParseReasoning method
Clear placeholder API key value in gpt-5 configuration
Diagram Walkthrough
File Walkthrough
LlmUtility.cs
Add fallback for missing model parameterssrc/Infrastructure/BotSharp.Abstraction/MLTasks/Utilities/LlmUtility.cs
ChatCompletionProvider.cs
Refactor reasoning effort level parsing logicsrc/Plugins/BotSharp.Plugin.OpenAI/Providers/Chat/ChatCompletionProvider.cs
appsettings.json
Clear placeholder API key valuesrc/WebStarter/appsettings.json