Bump SciMLBase minimum version to 1.52 #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous lower bound of `SciMLBase = "1"` was incorrect because this package uses `SciMLBase.AutoSpecialize`, which was not added to SciMLBase until version 1.52.0. Testing confirmed: - SciMLBase v1.51.0: FAILS with "UndefVarError: `AutoSpecialize` not defined" - SciMLBase v1.52.0: Works correctly 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
"1, 2"to"1.52, 2"Rationale
The previous lower bound of
SciMLBase = "1"was incorrect because this package usesSciMLBase.AutoSpecialize, which was not added to SciMLBase until version 1.52.0.Testing
Binary search testing was performed to identify the exact minimum version:
UndefVarError: AutoSpecialize not defined in SciMLBaseUndefVarError: AutoSpecialize not defined in SciMLBaseThe error with lower versions:
This occurs because the code in
src/solve.jlusesSciMLBase.AutoSpecializeas the default specialization type:cc @ChrisRackauckas
🤖 Generated with Claude Code