1294 add LCT SECIR model with two disease strains#1340
Conversation
started changing Infection States, Parameters etc. to reflect 2 diseases
changed Infection States, Parameters etc. to reflect 2 diseases
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1340 +/- ##
==========================================
+ Coverage 97.31% 97.38% +0.07%
==========================================
Files 187 189 +2
Lines 16019 16532 +513
==========================================
+ Hits 15589 16100 +511
- Misses 430 432 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
annawendler
left a comment
There was a problem hiding this comment.
In a recent commit the use of floating point types was reworked to allow for automatic differentiation. This also affected the LCT-SECIR model, e.g. we now have an additional template parameter FP for the model class. Can you adapt your model accordingly so that the models are consistent? If you have any questions just let us know :)
|
@an-jung please use capitalization in github for shorthand notation such as LCT, SECIR, ... |
annawendler
left a comment
There was a problem hiding this comment.
Remaining part of review. Looks good in general! The interact() function was a bit unclear to me, see questions below. Otherwise my comments are mainly regarding documentation
annawendler
left a comment
There was a problem hiding this comment.
Looks good to me! :) I only have minor comments regarding naming of some variables.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1294