Replace SmootherTake macros with type-safe functions#163
Merged
julianlitz merged 6 commits intomainfrom Feb 4, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 89.41% 90.11% +0.70%
==========================================
Files 91 91
Lines 5241 5614 +373
==========================================
+ Hits 4686 5059 +373
Misses 555 555 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EmilyBourne
reviewed
Feb 4, 2026
EmilyBourne
approved these changes
Feb 4, 2026
Collaborator
EmilyBourne
left a comment
There was a problem hiding this comment.
Looks good to me. Did you check if the timings were affected to see if we need to increase --param max-inline-insns-single further?
Collaborator
Author
|
@Emily I can't really look into the benchmarks further, since my laptop is just not powerful and reliable enough. The timings looked fine, though I can't say for sure. We could check later whether changing this instructions number impacts the runtime performance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the macros with inline functions to improve type safety and code maintainability without sacrificing performance. This is part of the broader effort to eliminate macro usage throughout GMGPolar.
Motivation
As discussed in #149, macros are error-prone and bypass C++'s type system, making bugs harder to catch at compile time. Macros in GMGPolar are currently used for code inlining, but modern C++ compilers handle inline functions just as efficiently in release builds while providing:
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):