Update gtest to 1.17.0 and fix Conan profile C++ standard#505
Merged
SavenkovIgor merged 3 commits intomainfrom Feb 7, 2026
Merged
Update gtest to 1.17.0 and fix Conan profile C++ standard#505SavenkovIgor merged 3 commits intomainfrom
SavenkovIgor merged 3 commits intomainfrom
Conversation
Co-authored-by: SavenkovIgor <339734+SavenkovIgor@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update gtest version to the latest
Update gtest to 1.17.0
Feb 7, 2026
SavenkovIgor
approved these changes
Feb 7, 2026
Co-authored-by: SavenkovIgor <339734+SavenkovIgor@users.noreply.github.com>
Copilot
AI
changed the title
Update gtest to 1.17.0
Update gtest to 1.17.0 and fix Conan profile C++ standard
Feb 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Conan test dependency on GoogleTest and aligns Conan profiles with the project’s C++23 standard so Conan can correctly resolve the toolchain configuration (fixing the compiler.cppstd CI failure).
Changes:
- Bump
gtesttest requirement from1.15.0to1.17.0inconanfile.py. - Add
compiler.cppstd=23to Conan profiles (clang base + wasm profiles) to match the project’s C++23 configuration.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| conanfile.py | Updates the gtest test dependency version to 1.17.0. |
| conanfiles/profile/base/clang_compiler | Adds compiler.cppstd=23 for clang-based desktop profiles via include(). |
| conanfiles/profile/wasm_dev | Adds compiler.cppstd=23 for Emscripten Debug builds. |
| conanfiles/profile/wasm_release | Adds compiler.cppstd=23 for Emscripten Release builds. |
Comments suppressed due to low confidence (2)
conanfile.py:2
- Import of 'CMakeDeps' is not used.
from conan.tools.cmake import CMakeToolchain, CMakeDeps, CMake
conanfile.py:3
- Import of 'os' is not used.
import os
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gtest 1.17.0 requires
compiler.cppstdto be explicitly set in Conan profiles. CI was failing with:Changes
compiler.cppstd=23to all profiles (base/clang_compiler, wasm_dev, wasm_release)The cppstd value matches the project's existing C++23 standard defined in CMakeLists.txt.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.