Skip to content

Conversation

@Saunved
Copy link
Owner

@Saunved Saunved commented Apr 13, 2023

No description provided.

@Saunved Saunved requested review from hritik5102 and nrkin April 13, 2023 12:25
@vercel
Copy link

vercel bot commented Apr 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-dev-workshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 0:49am

@Saunved Saunved self-assigned this Apr 13, 2023
@Saunved Saunved changed the base branch from feature/checkpoints to main April 13, 2023 12:26
{uiText.registerCta}
</h1>
<div className="mt-8 flex justify-center">
<div className="w-6/12">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added to fit the email and password failure message callout in one line, if you remove this, it might go on the second line. let me know if you were able to reproduce this. Waiting for ack

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay if it wraps to second line as long as it doesn't look "bad". We can fix this in a future commit but capping the width here shouldn't be our way of solving it.

Copy link
Collaborator

@hritik5102 hritik5102 Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that makes sense.

Copy link
Collaborator

@hritik5102 hritik5102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants