feat(macos): hide dock icon and add startup error dialog#141
Open
Olamshin wants to merge 1 commit intoSathvik-Rao:mainfrom
Open
feat(macos): hide dock icon and add startup error dialog#141Olamshin wants to merge 1 commit intoSathvik-Rao:mainfrom
Olamshin wants to merge 1 commit intoSathvik-Rao:mainfrom
Conversation
- Add PyInstaller spec file with LSUIElement to hide dock icon - Use NSApplicationActivationPolicyAccessory to fully hide dock icon - Add native macOS error dialog using osascript for startup crashes - Add tkinter and pyinstaller to requirements_mac.txt - Update .gitignore with build artifacts
Author
|
it is not clear to me if there is any build automation/steps. To build this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
osascriptso users see errors instead of silent failuresLSUIElement: Truein Info.plistChanges
NSApplicationActivationPolicyAccessoryvia AppKit to hide dock icon after tkinter initializationshow_error_dialog()function using native macOSosascriptfor startup error displayLSUIElement: Trueandtkinterhidden importpyinstallerdependencybuild/,dist/,.venv/)Fixes #101