Generalize Corfunc Slider #3833
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors the Corfunc slider into a reusable component so it can be shared by Invariant, making the slider generic and reusable for components that need different constraint semantics (e.g., Invariant needs to permit extrapolation beyond the raw data).
CorfuncSlider.pyout ofsrc/sas/qtgui/Perspectives/CorfuncExtrapolationSlider.pyand places insrc/sas/qtgui/Utilitiessrc/sas/sascalc/corfunc/calculation_data.pytosrc/sas/sascalc/util.pyBehavioural change (boundaries)
Introduces two distinct boundary pairs used by different callers:
Usage differences:
Corfunc: uses Data range only (no functional change except location/imports).
Invariant: uses both:
Fixes #3824
How Has This Been Tested?
Ran the program and tested the slider functionality in both perspectives.
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)